LSPS2: ability to signal channel open failure #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncantrell97
changed the title
johncantrell97
force-pushed
the
signal-channel-open-failure
branch
from
494a03c
to
8a7886c
Compare
This was referenced May 17, 2024
johncantrell97
force-pushed
the
signal-channel-open-failure
branch
from
8a7886c
to
b82779c
Compare
tnull
reviewed
May 29, 2024
| /// | ||
| /// Should be called in response to receiving a [`LSPS2ServiceEvent::OpenChannel`] event. | ||
| /// | ||
| /// The JIT channel state is reset such that the payer can attempt payment again. |
There was a problem hiding this comment.
I wonder if we also expose a "abandon" variant that doesn't reset, but just prunes all state related to the channel open?
| @@ -898,6 +904,79 @@ where | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Used by LSP to fail intercepted htlcs backwards when the channel open fails for any reason. | |||
| /// | |||
| /// Should be called in response to receiving a [`LSPS2ServiceEvent::OpenChannel`] event. | |||
There was a problem hiding this comment.
This comment is a bit misleading. It should be called after we get the event, but of course only if the channel open failed?
| @@ -49,8 +49,8 @@ impl PaymentQueue { | |||
| position.map(|position| self.payments.remove(position)) | |||
| } | |||
|
|
|||
| pub(crate) fn clear(&mut self) -> Vec<InterceptedHTLC> { | |||
| self.payments.drain(..).map(|(_k, v)| v).flatten().collect() | |||
| pub(crate) fn clear(&mut self) -> Vec<(PaymentHash, Vec<InterceptedHTLC>)> { | |||
There was a problem hiding this comment.
nit: Not sure this change is worth as it makes things more complex and you only make use of it in one place where you then have to map to get rid of the InterceptedHTLCs. Why not just use InterceptedHTLC::payment_hash instead? If you're worried about duplicates, could just use dedup or collect a HashSet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130
There are a number of reasons a channel open might fail or be abandoned by the LSP. This adds a way for the LSP to signal back to the library that this has happened.
All pending payments are failed backwards and the channel state is reset to PendingInitialPayment as per the spec. This allows the payer to try again.