-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Fix a wrong message when deleting a test run
#9191
Exam mode
: Fix a wrong message when deleting a test run
#9191
Conversation
WalkthroughThe recent updates enhance the localization capabilities of the application by adding new entries for deleted test runs in both the German and English JSON files. This improvement provides users with clear notifications about the deletion of test runs, thereby improving communication and maintaining existing information regarding submission failures. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense.
Can you maybe remove the quotes around the of since it's a integer and not a string? Or completely remove it since regular users won't have any use for the id anyways.
9ac6ae7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, Tested on TS6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS6, works as expected
General
: Fix the issue where a wrong message is displayed when deleting a test runExam mode
: Fix a wrong message when deleting a test run
Checklist
General
Client
Motivation and Context
It fixes the issues #9187 and #8901.
Description
Added messages for deleting a test run
Steps for Testing
(You can test it with any exams. So you just need to find a course with an exam. I have already one under my course on TS6.)
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Screenshots
Before
After
Summary by CodeRabbit
Summary by CodeRabbit