Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Fix a wrong message when deleting a test run #9191

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

edkaya
Copy link
Contributor

@edkaya edkaya commented Aug 5, 2024

Checklist

General

Client

  • I strictly followed the client coding and design guidelines.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

It fixes the issues #9187 and #8901.

Description

Added messages for deleting a test run

Steps for Testing

(You can test it with any exams. So you just need to find a course with an exam. I have already one under my course on TS6.)
Prerequisites:

  • 1 Instructor
  • 1 Exam
  1. Log in to Artemis
  2. Navigate to Course Administration
  3. Go to the Exam
  4. Click Test Run
  5. Create a Test Run
  6. Delete the Test Run
  7. Verify that the correct message is displayed

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Before
image
After
Screenshot 2024-08-05 at 18 43 55
Screenshot 2024-08-05 at 18 44 07

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Added user-facing messages for deleted test runs in both English and German localization files.
    • Enhanced user feedback regarding the status of exam submissions.

@edkaya edkaya requested a review from a team as a code owner August 5, 2024 13:03
@edkaya edkaya linked an issue Aug 5, 2024 that may be closed by this pull request
Copy link

coderabbitai bot commented Aug 5, 2024

Walkthrough

The recent updates enhance the localization capabilities of the application by adding new entries for deleted test runs in both the German and English JSON files. This improvement provides users with clear notifications about the deletion of test runs, thereby improving communication and maintaining existing information regarding submission failures.

Changes

Files Change Summary
.../i18n/de/exam.json, .../i18n/en/exam.json Added a new key "deleted" with appropriate messages for indicating that a test run has been deleted. Existing messages for submission failures remain unchanged.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Aug 5, 2024
@edkaya edkaya added the small label Aug 5, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Aug 5, 2024
JohannesStoehr
JohannesStoehr previously approved these changes Aug 5, 2024
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Strohgelaender
Strohgelaender previously approved these changes Aug 5, 2024
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense.

Can you maybe remove the quotes around the of since it's a integer and not a string? Or completely remove it since regular users won't have any use for the id anyways.

Copy link
Contributor

@PaRangger PaRangger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, Tested on TS6

Copy link

@anian03 anian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS6, works as expected

@edkaya edkaya added this to the 7.5.0 milestone Aug 6, 2024
@krusche krusche changed the title General: Fix the issue where a wrong message is displayed when deleting a test run Exam mode: Fix a wrong message when deleting a test run Aug 6, 2024
@krusche krusche merged commit cda2ecf into develop Aug 6, 2024
24 of 30 checks passed
@krusche krusche deleted the bugfix/exam-mode/display-test-run-delete-message branch August 6, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready to merge small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Exam: wrong message when I delete a run test
7 participants