fix(ui): Timeline::send_reply correctly sets up m.mentions
#3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
fix-3314
branch
2 times, most recently
from
ee3d97d
to
09496a0
Compare
In matrix-org#2691, I suppose the way `add_mentions` is computed is… wrong. `AddMentions` is used to automatically infer the `m.mentions` of the reply event based on the replied event. The way it was computed was based on the reply event `mentions`, which seems wrong: if the reply contains mentions, then the sender should be part of it? Nah. That's a bug. We want the reply event to automatically mention the sender of the replied event if and only if it's not the same as the current user, i.e. the sender of the reply event. This patch fixes the `add_mentions` calculation. This patch also updates a test and adds another test to ensure that `m.mentions` is correctly defined when replying to an event.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3341 +/- ##
==========================================
- Coverage 83.58% 83.58% -0.01%
==========================================
Files 240 240
Lines 24841 24843 +2
==========================================
+ Hits 20764 20765 +1
- Misses 4077 4078 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2691, I suppose
the way
add_mentionsis computed is… wrong.AddMentionsis used toautomatically infer the
m.mentionsof the reply event based on thereplied event. The way it was computed was based on the reply event
mentions, which seems wrong: if the reply contains mentions, then thesender should be part of it? Nah. That's a bug. We want the reply event
to automatically mention the sender of the replied event if and only
if it's not the same as the current user, i.e. the sender of the reply
event.
This patch fixes the
add_mentionscalculation. This patch also updatesa test and adds another test to ensure that
m.mentionsis correctlydefined when replying to an event.