Commits on Apr 23, 2024

1. fix(ui): Timeline::send_reply correctly sets up m.mentions. …

   In matrix-org#2691, I suppose
   the way `add_mentions` is computed is… wrong. `AddMentions` is used to
   automatically infer the `m.mentions` of the reply event based on the
   replied event. The way it was computed was based on the reply event
   `mentions`, which seems wrong: if the reply contains mentions, then the
   sender should be part of it? Nah. That's a bug. We want the reply event
   to automatically mention the sender of the replied event if and only
   if it's not the same as the current user, i.e. the sender of the reply
   event.
   
   This patch fixes the `add_mentions` calculation. This patch also updates
   a test and adds another test to ensure that `m.mentions` is correctly
   defined when replying to an event.

   

   Hywan committed Apr 23, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 97ce574
   • Browse repository at this point

   Copy the full SHA

   97ce574 View commit details

   Browse the repository at this point in the history