MNT: Apply assorted repo-review rules #3682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PP002: Has a proper build-system table Must have `build-system.requires` and `build-system.backend`. Both should be present in all modern packages.
PP003: Does not list wheel as a build-dep Do not include `"wheel"` in your `build-system.requires`, setuptools does this via PEP 517 already. Setuptools will also only require this for actual wheel builds, and might have version limits.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3682 +/- ##
===========================================
- Coverage 70.83% 39.49% -31.34%
===========================================
Files 1276 1276
Lines 59314 59314
Branches 9824 9824
===========================================
- Hits 42013 23427 -18586
- Misses 16125 35729 +19604
+ Partials 1176 158 -1018 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://learn.scientific-python.org/development/guides/repo-review/?repo=nipy%2Fnipype&branch=master