Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Apply assorted repo-review rules #3682

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MNT: Apply assorted repo-review rules #3682

wants to merge 2 commits into from

Commits on Sep 23, 2024

  1. MNT: Apply repo-review rule PP002 

    PP002: Has a proper build-system table

Must have `build-system.requires` and `build-system.backend`.
Both should be present in all modern packages.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0f36ab9 View commit details
    Browse the repository at this point in the history

  2. MNT: Apply repo-review rule PP003 

    PP003: Does not list wheel as a build-dep

Do not include `"wheel"` in your `build-system.requires`, setuptools does
this via PEP 517 already. Setuptools will also only require this for actual
wheel builds, and might have version limits.
    @DimitriPapadopoulos
    DimitriPapadopoulos committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    cf21cad View commit details
    Browse the repository at this point in the history