Write directions sidebar header using .erb template #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should try to enable/disable the form input listeners first. Then all of the loading could be done in load/popstate methods. |
AntonKhorev
force-pushed
the
directions-template
branch
from
78d3b47
to
67fa99d
Compare
|
I have |
AntonKhorev
force-pushed
the
directions-template
branch
from
67fa99d
to
db71701
Compare
AntonKhorev
force-pushed
the
directions-template
branch
from
db71701
to
124dd1c
Compare
|
I did the thing above but there's still blinking caused by |
AntonKhorev
force-pushed
the
directions-template
branch
from
124dd1c
to
d06c433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other sidebar pages have at least a heading and some placeholder in their
.html.erbtemplate, for example geocoder search. Directions search is the exception, it's template is essentially empty. Instead everything is written bydirections.js.Here I'm moving the directions heading to
.html.erb. Actually I'm doing this to add more things to.html.erblater. Preview: #4901.