Skip cluster port group operations for UDN #4738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tssurya
added
kind/bug
tssurya
force-pushed
the
udn-fix-noise
branch
from
6662803
to
b0c2a8a
Compare
dceara
approved these changes
Sep 19, 2024
|
@tssurya we might want a more descriptive name than |
updated the PR description, I guess the first thing that pops into the reviewers head when they hear fix noise is... what noise.. then they will read the PR description which had details but.. your method is more efficient where I just tell that in the title ;) you win. |
We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get ovn-org#4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <[email protected]>
tssurya
force-pushed
the
udn-fix-noise
branch
from
b0c2a8a
to
0055e7f
Compare
kyrtapz
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We kept trying to add the management port
for secondary networks into the cluster
port group of secondary networks.
But that port group doesn't exist yet.
It will exist once we get #4547 merged but until then this is causing
infinite retries from syncMgmtPort
erroring out. So let's skip this for now
PS: Not really infinite, only 15 times..