Create an action to push some ARM builds to PyPI #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mac run failed, this could be related to the old miniconda setup
ajjackson
force-pushed
the
gh-action-twiddling
branch
from
43aec44
to
aa455ce
Compare
For 1.3.2 we built on x86 Mac (macos-13) but it would be good to have (and test) some ARM wheels as well. We're having trouble building those on older Python versions, but if we upload 3.10 and 3.11 wheels to PyPI that should be somewhat useful. This action is not intended to stick around once py3.8 and 3.9 are deprecated; then we will try to build intel and ARM wheels in the same job.
ajjackson
force-pushed
the
gh-action-twiddling
branch
from
aa455ce
to
6a2c73a
Compare
This needs to be built against the version-tagged commit or the filenames are wrong for PyPI
workflow_dispatch from non-master doesn't seem to be registering. Instead let's try directly checking-out the target release.
Test Results 41 files + 19 41 suites +19 1h 50m 26s ⏱️ + 1h 17m 39s For more details on these failures, see this check. Results for commit 327d04a. ± Comparison against base commit e85ded5. ♻️ This comment has been updated with latest results. |
- The push trigger allowed a one-time ARM build which has now been manually pushed up to PyPI. (Automatic push didn't work, needed to download artifacts and use twine.) Remove it so the CI doesn't keep rebuilding and failing push. - Now let's confirm that the expected configurations work by testing the PyPI release on both Intel and ARM Mac. (I'm expecting that Intel (macos-13) will work across versions, and ARM (macos-latest) will get the new wheels, while failing to build on Python 3.8, 3.9.)
Troubleshooting test failures here... I *think* the wheels are all built against pre-v2 numpy and so this test is failing due to the ABI change when test runner uses a newer version. In this case we can go ahead and make a new release that builds against the newer Numpy ABI, which requires the min version to be increased to 1.25. One issue will be that Mantid is still on 1.24.
ajjackson
force-pushed
the
gh-action-twiddling
branch
from
54d08cb
to
5e23cf9
Compare
Conda can't install 1.20 so we weren't getting useful information from the failure.
|
This branch was used to run some Actions but is not intended for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.