Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an action to push some ARM builds to PyPI #306

Closed
wants to merge 8 commits into from

Commits on Jul 16, 2024

  1. Update test_release github actions

    Mac run failed, this could be related to the old miniconda setup
    ajjackson committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ee6c010 View commit details
    Browse the repository at this point in the history
  2. Create a special action to upload version-limited Mac-ARM wheels

    For 1.3.2 we built on x86 Mac (macos-13) but it would be good to
    have (and test) some ARM wheels as well. We're having trouble building
    those on older Python versions, but if we upload 3.10 and 3.11 wheels
    to PyPI that should be somewhat useful.
    
    This action is not intended to stick around once py3.8 and 3.9 are
    deprecated; then we will try to build intel and ARM wheels in the same
    job.
    ajjackson committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6a2c73a View commit details
    Browse the repository at this point in the history
  3. Change ARM build to a workflow dispatch

    This needs to be built against the version-tagged commit or the
    filenames are wrong for PyPI
    ajjackson committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    abb7b49 View commit details
    Browse the repository at this point in the history
  4. Mac ARM build/push against release

    workflow_dispatch from non-master doesn't seem to be
    registering. Instead let's try directly checking-out the target release.
    ajjackson committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a147a24 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Release test on Mac intel/ARM; remove push trigger for ARM build

    - The push trigger allowed a one-time ARM build which has now been
      manually pushed up to PyPI. (Automatic push didn't work, needed to
      download artifacts and use twine.) Remove it so the CI doesn't keep
      rebuilding and failing push.
    
    - Now let's confirm that the expected configurations work by testing
      the PyPI release on both Intel and ARM Mac.
    
      (I'm expecting that Intel (macos-13) will work across versions, and
       ARM (macos-latest) will get the new wheels, while failing to build
       on Python 3.8, 3.9.)
    ajjackson committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8dd48f3 View commit details
    Browse the repository at this point in the history
  2. Release test against Numpy < 2

    Troubleshooting test failures here... I *think* the wheels are all
    built against pre-v2 numpy and so this test is failing due to the ABI
    change when test runner uses a newer version.
    
    In this case we can go ahead and make a new release that builds
    against the newer Numpy ABI, which requires the min version to be
    increased to 1.25.
    
    One issue will be that Mantid is still on 1.24.
    ajjackson committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5e23cf9 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Fix tox requirements format

    ajjackson committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    327d04a View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Bump the conda-py38-old-np numpy version to 1.22

    Conda can't install 1.20 so we weren't getting useful information from
    the failure.
    ajjackson committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    83926d1 View commit details
    Browse the repository at this point in the history