Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 0.4.0 #106

Merged
merged 48 commits into from
Sep 4, 2024
Merged

Update to version 0.4.0 #106

merged 48 commits into from
Sep 4, 2024

Conversation

mattheww95
Copy link
Collaborator

Update mikrokondo to version 0.4.0.

See CHANGELOG.md for updates.

mattheww95 and others added 18 commits July 25, 2024 12:08
* starting locidex database integrations

* updated added new files

* updated locidex db identification

* updated automated allele selection

* updated todos

* added test data for locidex databases, tests should still function:

* updated nextflow schema.json

* Removed tests for comparing updates for old and new locidex profiles

Perhaps the relevant fields should be sub set out

* removed dead test file

* updated test profile

* restrucutured file staging for locidex select

* started creation of real tests for locidex workflow

* updated locidex test data

* updated locidex workflow and tests

* updated docker container

* addressed PR issues, still more work to be done

* updated database selection functions to get an optimal match

* added skipped allele calling to test config

* updated test conditions

* updated test files

* updated locidex select paths

* removed trailing whitespace

* updated tests to include passing cases

* added locidex summary process

* updated fixe issues with integer sizing

* debugging summary test

* Added field for reportable alleles

* updated reportable loci test

* updated locidex summary tests

* updated missing allelels JSON type

* upated not database selected output

* updated IRIDANEXT config for locidex values

* updated locidex end-to-end tests

* updated locations of locidex test

* zipped and updated sample datasets

* upated locidex end to end tests

* fixed typos in change log

* updated locidex tests

* cleaned up datebase name parsing

* fixed code comment

* updated code comments

* made updates on PR comments

* normalized output for iridanext across allele scheme input options

* updated test cases

* updated locidex_select tests to match updated interface

* updated test to work in github actions

* removed sneaky todo

* updating issues identified and regression in kraken2 header parsing

* reverted zipped file handling

* fixed regression locidex select

* removed repeated variables

* updated staging of report input to locidex summarize

* updated file parsing in locidex summarize

Thank you Aaron!

* updated changelog

* extracted inline code in function

* bumped locidex container

* updated final todos

* updated options to locidex_select test to terminate processes on failure
…LST (#98)

* updated Torsteins mlst container, as results were differing with PubMLST

* updated wordslist

* updated test to use e.coli achtman 4

* update listeria scheme selection

* updated changelog statement
#102)

* updated tests running average coverage calculations in cloud executors

* committing progress, difference in behaviour between nextflow versions is being observed

* fixed missing coverage value in version 24 of nextflow

* updated test ouputs

* removed docker.userEmulation as marked as deprecated

* renamed duplicated test name
dropped quay.io from docker paths
* fixed typo and metagenomic QCSummary message

* updated changelog

* removed comma

* updated metagenomic tests

* added missing test files

* updated virus mash sketch

* updated output values

* fixed test typo

* reintegrated deleted test
* updated config defaults for various organisms

* updated changelog
* updated parameters for allele schema

* updated changelog

* fixed error in parameter updates

* fixed misspelled param

* updated test config

* updated CLI argument

* dropped allele scheme used from the irida-next config

* updated tests to pass

* updated container default settings

* updated changelog and version
Copy link

github-actions bot commented Sep 4, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7093f01

+| ✅ 223 tests passed       |+
#| ❔  31 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 0.4.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/mikrokondo/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/mikrokondo/main/nextflow_schema.json

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-mikrokondo_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-mikrokondo_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-mikrokondo_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: docs/output.md
  • files_exist - File is ignored: docs/README.md
  • files_exist - File is ignored: docs/usage.md
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-mikrokondo_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-mikrokondo_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-mikrokondo_logo_dark.png
  • files_unchanged - File does not exist: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/mikrokondo/mikrokondo/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-04 20:50:12

@mattheww95 mattheww95 merged commit c32ce85 into main Sep 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants