XCUITest type added (similar to XCTest) #1937
Conversation
| @@ -243,6 +243,13 @@ | |||
| test.isequal("bin/Debug/MyProject.xctest/Contents/MacOS", path.getrelative(os.getcwd(), i.bundlepath)) | |||
| end | |||
|
|
|||
| function suite.bundlepathSet_onMacSharedLibXCUITest() | |||
There was a problem hiding this comment.
Please add documentation to this test.
There was a problem hiding this comment.
Can you point me to where pls? Happy to do so.
There was a problem hiding this comment.
Just look at other unit tests above and add the doc comment
| @@ -409,6 +409,14 @@ | |||
| test.contains({ "-Wl,-x", "-bundle" }, gcc.getldflags(cfg)) | |||
| end | |||
|
|
|||
| function suite.ldflags_onMacOSXXCUITest() | |||
There was a problem hiding this comment.
Please add documentation to this test.
| @@ -10,6 +10,7 @@ sharedlibtype "value" | |||
| * `OSXBundle` - needs documentation. | |||
| * `OSXFramework` - needs documentation. | |||
| * `XCTest` - needs documentation. | |||
| * `XCUITest`- needs documentation. | |||
There was a problem hiding this comment.
If you're able to add documentation to describe this, do you mind doing so? That's basically a TODO for us when we updated our docs to get documentation added to fields.
There was a problem hiding this comment.
Sure, I'll get to it after the holidays, wasn't sure if you're OK with doing this in same PR.
There was a problem hiding this comment.
Hmm, good point about same PR. It may make sense to just touch this line in this PR, then do the rest in a follow up. I don't have a huge preference either way, since the PR will stay small.
There was a problem hiding this comment.
Sure, I'll get to it after the holidays, wasn't sure if you're OK with doing this in same PR.
Not sure when the holidays end for you. I'm trying to start prepping a new release build of Premake. Will this be ready by the weekend?
There was a problem hiding this comment.
No, I'm back on 5th, so that week would be earliest. No rush on my side, we run custom fork until it gets merged. Thanks.
This PR adds the support for the XCUITest type for XCode projects. It is very similar to XCTest, with most things being the same, but it's a different
productTypethan the XCTest.Don't expect any breaking change, because this is an addition. And I have also added tests.