-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCUITest type added (similar to XCTest) #1937
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -409,6 +409,14 @@ | |
test.contains({ "-Wl,-x", "-bundle" }, gcc.getldflags(cfg)) | ||
end | ||
|
||
function suite.ldflags_onMacOSXXCUITest() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add documentation to this test. |
||
system "MacOSX" | ||
kind "SharedLib" | ||
sharedlibtype "XCUITest" | ||
prepare() | ||
test.contains({ "-Wl,-x", "-bundle" }, gcc.getldflags(cfg)) | ||
end | ||
|
||
function suite.ldflags_onMacOSXFramework() | ||
system "MacOSX" | ||
kind "SharedLib" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ sharedlibtype "value" | |
* `OSXBundle` - needs documentation. | ||
* `OSXFramework` - needs documentation. | ||
* `XCTest` - needs documentation. | ||
* `XCUITest`- needs documentation. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you're able to add documentation to describe this, do you mind doing so? That's basically a TODO for us when we updated our docs to get documentation added to fields. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That would be great. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, I'll get to it after the holidays, wasn't sure if you're OK with doing this in same PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, good point about same PR. It may make sense to just touch this line in this PR, then do the rest in a follow up. I don't have a huge preference either way, since the PR will stay small. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Not sure when the holidays end for you. I'm trying to start prepping a new release build of Premake. Will this be ready by the weekend? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, I'm back on 5th, so that week would be earliest. No rush on my side, we run custom fork until it gets merged. Thanks. |
||
|
||
### Applies To ### | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add documentation to this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you point me to where pls? Happy to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just look at other unit tests above and add the doc comment