Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use reusable-reviewer-lottery from ros2_control_ci #1402

Merged

Conversation

christophfroehlich
Copy link
Contributor

This is a fix to #1395: The reviewer-lottery action only takes files from the local filesystem, which makes the action fail as reported here.

To fix this, I added a reusable workflow to ros2_control_ci using wget to download the config file.

I tested this here, this should work now.

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Feb 17, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (786d5b5) 47.49% compared to head (d640e44) 75.88%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1402       +/-   ##
===========================================
+ Coverage   47.49%   75.88%   +28.38%     
===========================================
  Files          41       41               
  Lines        3556     3359      -197     
  Branches     1938     1935        -3     
===========================================
+ Hits         1689     2549      +860     
+ Misses        459      419       -40     
+ Partials     1408      391     -1017     
Flag Coverage Δ
unittests 75.88% <ø> (+28.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

@saikishor
Copy link
Member

@christophfroehlich I've a question, does this job also take into account the github.actor conditions that we have currently?

@christophfroehlich
Copy link
Contributor Author

@christophfroehlich I've a question, does this job also take into account the github.actor conditions that we have currently?

You mean this here? Afaik this is correctly used from the reusable workflow

@saikishor
Copy link
Member

Yes that one! Awesome thanks

@christophfroehlich christophfroehlich added the backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. label Feb 17, 2024
@bmagyar bmagyar merged commit c4affe4 into ros-controls:master Feb 19, 2024
16 of 17 checks passed
mergify bot pushed a commit that referenced this pull request Feb 19, 2024
mergify bot pushed a commit that referenced this pull request Feb 19, 2024
@christophfroehlich christophfroehlich deleted the fix_reviewer_lottery branch February 19, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants