Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rqt_controller_manager] Add hardware components #1455

Merged
merged 18 commits into from
Jun 25, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Mar 23, 2024

In addition to #1248 I'd like to add the hardware components to the rqt_controller_manger.

It could also be a different rqt window, but if it is all in one we have the benefit of advertising hardware component lifecycles too.

image

Tooltip
image

It includes #1454 and #1447, but I hope they will get merged earlier.

@christophfroehlich christophfroehlich added enhancement backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Mar 23, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments. The rest looks good to me. Thanks for the nice feature

controller_manager/doc/userdoc.rst Outdated Show resolved Hide resolved
controller_manager/doc/userdoc.rst Outdated Show resolved Hide resolved
controller_manager/doc/userdoc.rst Outdated Show resolved Hide resolved
controller_manager/doc/userdoc.rst Outdated Show resolved Hide resolved
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmagyar bmagyar merged commit 7ffe1b7 into ros-controls:master Jun 25, 2024
6 of 11 checks passed
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@christophfroehlich christophfroehlich deleted the rqt_cm_add_hw branch June 25, 2024 11:24
christophfroehlich added a commit that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants