solve catkin_lint errors #176
Conversation
robotiq_ft_sensor/package.xml
Outdated
| @@ -2,7 +2,7 @@ | |||
| <package format="2"> | |||
| <name>robotiq_ft_sensor</name> | |||
| <version>1.0.0</version> | |||
| <description>Package for reading data from a Robotiq Force Torque Sensor</description> | |||
| <description><p2>Package for reading data from a Robotiq Force Torque Sensor</p2></description> | |||
There was a problem hiding this comment.
Should this be a <p> instead of a <p2>?
Also: did catkin_lint really complain about this?
There was a problem hiding this comment.
yes and no, catkin_lint gives a warning if the description of the package starts with "package for" or "package to" or "this package..." saying that this is the boilerplate informaion. I am not familiar with these packages and I don't feel comfortable changing their description, then I decided to add there a new format to makes catkin_lint happy..
There was a problem hiding this comment.
again, thanks! I will update this
| add_executable(${PROJECT_NAME}_node | ||
| include/${PROJECT_NAME}/${PROJECT_NAME}.h | ||
| src/${PROJECT_NAME}.cpp | ||
| src/${PROJECT_NAME}_node.cpp | ||
| ) |
There was a problem hiding this comment.
I would have probably left these alone, but if catkin_lint likes this better ..
| @@ -23,4 +23,6 @@ | |||
| <depend>robotiq_2f_gripper_control</depend> | |||
| <depend>roscpp</depend> | |||
|
|
|||
| <build_depend>message_generation</build_depend> | |||
There was a problem hiding this comment.
Should <exec_depend>message_runtime</exec_depend> also be added?
There was a problem hiding this comment.
Actually even the message_generation dependency was not needed, this package is not generating messages. I will remove it here and for the CMakeLists
Thanks!
| @@ -2,7 +2,7 @@ | |||
| <package format="2"> | |||
| <name>robotiq_2f_gripper_control</name> | |||
| <version>1.0.0</version> | |||
| <description>Package to control a 2-Finger Gripper from Robotiq inc.</description> | |||
| <description><p>Package to control a 2-Finger Gripper from Robotiq inc.</p></description> | |||
There was a problem hiding this comment.
Is this a new thing for catkin_lint to complain about?
There was a problem hiding this comment.
(copy-paste) yes and no, catkin_lint gives a warning if the description of the package starts with "package for" or "package to" or "this package..." saying that this is the boilerplate informaion. I am not familiar with these packages and I don't feel comfortable changing their description, then I decided to add there a new format to makes catkin_lint happy..
| @@ -27,6 +27,7 @@ | |||
|
|
|||
| <build_depend>angles</build_depend> | |||
| <build_depend>message_generation</build_depend> | |||
| <build_depend>gazebo</build_depend> | |||
There was a problem hiding this comment.
Should this be gazebo_ros instead?
There was a problem hiding this comment.
no, gazebo_ros is already listed. Catkin_lint gave the following error:
robotiq_3f_gripper_articulated_gazebo_plugins: error: missing build_depend on 'gazebo'
catkin_lint: checked 17 packages and found 1 problems
| @@ -2,7 +2,7 @@ | |||
| <package format="2"> | |||
| <name>robotiq_3f_gripper_control</name> | |||
| <version>1.0.0</version> | |||
| <description>Package to control a 3F gripper Gripper from Robotiq inc.</description> | |||
| <description><p2>Package to control a 3F gripper Gripper from Robotiq inc.</p2></description> | |||
There was a problem hiding this comment.
| <description><p2>Package to control a 3F gripper Gripper from Robotiq inc.</p2></description> | |
| <description><p>Package to control a 3F gripper Gripper from Robotiq inc.</p></description> |
There was a problem hiding this comment.
Ups! Thanks, I will modify this
|
Thanks for addressing my comments. I'm going to leave a detailed review to @jproberge, as he is the current maintainer of these packages. Given your result: I suggest we mark this one as |
Related to #26