add: get clients, servers info #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Minju, Lee <[email protected]>
leeminju531
requested review from
methylDragon,
ivanpauno and
wjwwood
as code owners
This was referenced Jun 25, 2024
This was referenced Jun 25, 2024
fujitatomoya
requested changes
Jul 3, 2024
There was a problem hiding this comment.
I think in rmw service endpoints are handled as topics internally, precisely client is DataReader and server is DataWriter to fill in the topic endpoint information. so all the field of rmw_topic_endpoint_info_t can be filled in with calling the graph cache.
IMO i think in rmw we can use rmw_topic_endpoint_info_t as it is now, but i would add comment that says this structure is used for service client and server as well.
| * This function returns an array of endpoint information for each client | ||
| * of a given service, as discovered so far by the given node. | ||
| * Endpoint information includes the client's node name and namespace, | ||
| * the associated topic type, the client's gid, and the client QoS profile. |
There was a problem hiding this comment.
Suggested change
| * the associated topic type, the client's gid, and the client QoS profile. | |
| * the associated service type, the client's gid, and the client QoS profile. |
| * of a given service, as discovered so far by the given node. | ||
| * Endpoint information includes the client's node name and namespace, | ||
| * the associated topic type, the client's gid, and the client QoS profile. | ||
| * Names of non-existent topics are allowed, in which case an empty array will be returned. |
There was a problem hiding this comment.
Suggested change
| * Names of non-existent topics are allowed, in which case an empty array will be returned. | |
| * Names of non-existent services are allowed, in which case an empty array will be returned. |
| * This function returns an array of endpoint information for each server | ||
| * of a given service, as discovered so far by the given node. | ||
| * Endpoint information includes the server's node name and namespace, | ||
| * the associated topic type, the server's gid, and the server QoS profile. |
There was a problem hiding this comment.
Suggested change
| * the associated topic type, the server's gid, and the server QoS profile. | |
| * the associated service type, the server's gid, and the server QoS profile. |
| * of a given service, as discovered so far by the given node. | ||
| * Endpoint information includes the server's node name and namespace, | ||
| * the associated topic type, the server's gid, and the server QoS profile. | ||
| * Names of non-existent topics are allowed, in which case an empty array will be returned. |
There was a problem hiding this comment.
Suggested change
| * Names of non-existent topics are allowed, in which case an empty array will be returned. | |
| * Names of non-existent services are allowed, in which case an empty array will be returned. |
|
@wjwwood Mind taking a look at this new rmw API 🧇 ? |
|
@leeminju531 , any updates from your end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get clients, servers info
Refer to ros2/ros2cli#916