-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add : get clients servers info #238
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Minju, Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of nitpicks.
rmw_reset_error(); | ||
EXPECT_EQ(RMW_RET_OK, rmw_topic_endpoint_info_array_check_zero(&clients_info)); | ||
|
||
// A null topic name is an invalid argument. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// A null topic name is an invalid argument. | |
// A null service name is an invalid argument. |
rmw_reset_error(); | ||
EXPECT_EQ(RMW_RET_OK, rmw_topic_endpoint_info_array_check_zero(&servers_info)); | ||
|
||
// A null topic name is an invalid argument. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// A null topic name is an invalid argument. | |
// A null service name is an invalid argument. |
Add get clients, servers info
Refer to ros2/ros2cli#916