-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Topology.Container.Dynamic] Add class TriangleSubdividers to store methods to subdivide a triangle in differents configurations #4747
Draft
epernod
wants to merge
16
commits into
sofa-framework:master
Choose a base branch
from
epernod:inf_2024_11_triangleSubdividers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the triangles positions and use real area as barycoef
… TriangleSubdivider
… confusion with TriangleSetTopologyModifier
epernod
added
pr: status to review
To notify reviewers to review this pull-request
pr: new feature
Implement a new feature
labels
May 20, 2024
[ci-build][with-all-tests] |
fredroy
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: new feature
Implement a new feature
pr: status wip
Development in the pull-request is still in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility class for
TriangleSetTopologyModifier
component.The class TriangleSubdivider is derived in 5 specializations to reflect the 5 possible scenario to subdivide a triangle.
Those subdividers will be used in the new version of Triangle incision in
TriangleSetGeometryAlgorithms
Todo, finish the tests:
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if