Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Allow different gravity vectors in Nodes #4876

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxbilger
Copy link
Contributor


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added the pr: status to review To notify reviewers to review this pull-request label Aug 1, 2024
@hugtalbot
Copy link
Contributor

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor

Interesting change @alxbilger
The Gravity component is available for this. But your change should make it more straightforward, I will give it a try

@hugtalbot hugtalbot added the enhancement About a possible enhancement label Aug 1, 2024
@hugtalbot
Copy link
Contributor

Tested and approved 👍

What do you think @alxbilger about setting gravity to "0 0 0" as default value?

@alxbilger
Copy link
Contributor Author

What do you think @alxbilger about setting gravity to "0 0 0" as default value?

I think it will break a lot of scenes

@alxbilger
Copy link
Contributor Author

I also think about creating a graph link instead of a simple copy:

if (!worldGravity_.isSet())
{
    worldGravity_.setParent(&c); ///< Gravity IN THE WORLD COORDINATE SYSTEM.
}

What do you think?

@hugtalbot
Copy link
Contributor

hugtalbot commented Aug 2, 2024

I think it will break a lot of scenes

I like it baby 🚒 🔥

I also think about creating a graph link instead of a simple copy:

🤔 why would you do that? I am unsure about side effect

@hugtalbot
Copy link
Contributor

I also think about creating a graph link instead of a simple copy:

why @alxbilger

@alxbilger
Copy link
Contributor Author

So that it can update if its parent has changed

@hugtalbot
Copy link
Contributor

To be noted, this change would only work in XML : SimpleAPI or Python do not change the "isSet" property as does the XML. I investigate on this currently

@hugtalbot
Copy link
Contributor

If #4911 is solved, then #4910 could replace this PR @alxbilger

@hugtalbot hugtalbot self-requested a review August 14, 2024 08:22
@hugtalbot hugtalbot added the pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. label Aug 14, 2024
@damienmarchal
Copy link
Contributor

damienmarchal commented Aug 28, 2024

@hugtalbot, isSet is switched to "true" at first value change (eg: any begin/write edit). Can you explain a bit what kind of behavior should be expected ?

@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. pr: status wip Development in the pull-request is still in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants