[FEM] Add method computeVonMisesStress in TetrahedralCorotationalForceField and option to draw them #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FEMForceField and method to draw it by Node
epernod
added
pr: status to review
epernod
changed the title
fredroy
requested changes
Sep 2, 2024
Comment on lines
+198
to
+200
| Data<type::vector<Real> > d_vonMisesPerNode; ///< von Mises Stress per node | ||
|
|
||
| sofa::helper::ColorMap* m_VonMisesColorMap; |
There was a problem hiding this comment.
Suggested change
| Data<type::vector<Real> > d_vonMisesPerNode; ///< von Mises Stress per node | |
| sofa::helper::ColorMap* m_VonMisesColorMap; | |
| Data<type::vector<Real> > d_vonMisesPerNode; ///< von Mises Stress per node | |
| sofa::helper::ColorMap* m_vonMisesColorMap; |
I guess this is a copy-paste from the other file 🫢but it is nice to have consistency
| matVert[k][l] = X0[ix][l - 1]; | ||
| } | ||
|
|
||
| const bool canInvert = type::invertMatrix(tetrahedronInf[i].elemShapeFun, matVert); |
There was a problem hiding this comment.
Suggested change
| const bool canInvert = type::invertMatrix(tetrahedronInf[i].elemShapeFun, matVert); | |
| [[maybe_unused]] const bool canInvert = type::invertMatrix(tetrahedronInf[i].elemShapeFun, matVert); |
| const TetrahedronInformation& tetraInfo = tetrahedronInf[i]; | ||
|
|
||
| computeRotationLarge(R_0_2, X, tetra[0], tetra[1], tetra[2]); | ||
| //tetraInfo.rotation.transpose(R_0_2); |
There was a problem hiding this comment.
Suggested change
| //tetraInfo.rotation.transpose(R_0_2); |
|
|
||
| if (d_drawing.getValue()) | ||
| { | ||
| std::vector< type::Vec3 > points[4]; |
There was a problem hiding this comment.
You could reserve the memory beforehand as the size seems computable
|
To me adding more and more hard coded drawing function by copy-pasting other's drawing function in every components is not desirable. I see two better solutions:
|
bakpaul
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to TetrahedronFEMForceField, compute von mises per element and add option to draw it.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if