-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Constraint.Lagrangian] Add augmented lagrangians #5003
Open
bakpaul
wants to merge
8
commits into
sofa-framework:master
Choose a base branch
from
bakpaul:test_augmented_lagrangians
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed to fix it then add virutalization in Contact response
bakpaul
added
pr: status to review
To notify reviewers to review this pull-request
pr: new feature
Implement a new feature
pr: highlighted in next release
Highlight this contribution in the notes of the upcoming release
labels
Sep 17, 2024
[ci-build][with-all-tests] |
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #5. To unlock the merge button, you must
|
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #6. To unlock the merge button, you must
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: highlighted in next release
Highlight this contribution in the notes of the upcoming release
pr: new feature
Implement a new feature
pr: status to review
To notify reviewers to review this pull-request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a first implementation of the augmented lagrangian collision (see A Surface-to-Surface Finite Element Algorithm for Large Deformation Frictional Contact).
To do so, because it is very close to the classical Unilateral constraint, I've tried to factorize code by adding a virtualization layer for both the constraints and the associated contact responses (see added class BaseContactLagrangianConstraint and BaseUnilateralContactResponse). It rely on a contact param template which is the only thing that differs in term of data and of course the type of ConstraintResolution used.
An example scene is introduced in the Demo folder, simply copying the falling beam example and replacing the response by the augmented lagrangian one.
There are still one todo for the future, even if this PR is already working on its own : adding the per-contact-point penalty modulation. This should be done by going back to the collision element using the DetectionOutput.elem attribute. This allows to go back to the topology. The only unknown is how to compute the element volume when the colliding topology is mapped to the simulated one.
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/142]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if