-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VK] Updated global header component with some additional required styles #584
base: main
Are you sure you want to change the base?
[VK] Updated global header component with some additional required styles #584
Conversation
toolkits/springernature/packages/springernature-header/scss/50-components/core.scss
Show resolved
Hide resolved
@@ -1,5 +1,7 @@ | |||
.c-header__content { | |||
position: relative; | |||
display: flex; | |||
justify-content: space-between; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flex rule kicks in with the media query just below.
the following should be added to the README
@import '@springernature/brand-context/default/scss/10-settings/breakpoints';
@import '@springernature/brand-context/default/scss/30-mixins/media-query';```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are done in README
toolkits/springernature/packages/springernature-header/scss/50-components/enhanced.scss
Outdated
Show resolved
Hide resolved
@@ -54,6 +54,7 @@ Import the core styles into your main stylesheet | |||
@import '@springernature/springernature-header/scss/10-settings/layout'; | |||
@import '@springernature/springernature-user-details/scss/10-settings/typography'; // if including user-details data | |||
@import '@springernature/springernature-user-details/scss/50-components/core'; // if including user-details data | |||
@import '@springernature/brand-context/springernature/scss/10-settings/typography'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import should probably occur above scss/10-settings/typography
…https://github.com/springernature/frontend-toolkits into Updated_global_header_package_with_some_required_css
Updated some essential style for common global header package with comments