Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VK] Updated global header component with some additional required styles #584

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[VK] Updated global header component with some additional required styles #584

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
70e841c
[VK] Updated global header common component with some additional requ…
Oct 13, 2021
cee5682
[VK] Updated global header as per PR review comments
Oct 14, 2021
f788af2
[VK] Updated global header core css as per PR review comments
Oct 14, 2021
7545ea4
Merge branch 'master' into Updated_global_header_package_with_some_re…
poojajain9450 Oct 21, 2021
22082b5
[VK] Global Header Updated README file as per review comments
Oct 26, 2021
67f7281
Merge branch 'Updated_global_header_package_with_some_required_css' o…
Oct 26, 2021
f80625e
[VK] Global Header Updated README file as per review comments
Oct 26, 2021
76d9f0d
Merge branch 'master' into Updated_global_header_package_with_some_re…
poojajain9450 Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions toolkits/springernature/packages/springernature-header/scss/50-components/core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@
font-size: 2.7rem;
}

font-family: $context--font-family-serif;
3697varun marked this conversation as resolved.
Show resolved Hide resolved
font-family: serif; // Font-family updated to serif
line-height: 4.6rem;
font-size: 2rem;
font-size: 1.5rem;
white-space: nowrap; // Added no-wrap for logo title
color: color('black');
}

Expand Down
3 changes: 3 additions & 0 deletions toolkits/springernature/packages/springernature-header/scss/50-components/enhanced.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
.c-header__content {
position: relative;
display: flex;
justify-content: space-between;

Copy link
Contributor

@jon-stevens jon-stevens Oct 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flex rule kicks in with the media query just below.
the following should be added to the README

@import '@springernature/brand-context/default/scss/10-settings/breakpoints';
@import '@springernature/brand-context/default/scss/30-mixins/media-query';```

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are done in README

@include media-query('sm') {
display: flex;
Expand All @@ -22,6 +24,7 @@

.c-header__site-logo {
padding-right: 20px;
border-right: 2px solid #222; // For SNAPP logo border-right
3697varun marked this conversation as resolved.
Show resolved Hide resolved
}

.c-header__journal-logo {
Expand Down