Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): move main to its own file and keep run infrastructure reusable #874

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 41.64456% with 220 lines in your changes missing coverage. Please review.

Project coverage is 74.27%. Comparing base (d450daf) to head (8187ed7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/run.rs 41.64% 189 Missing and 31 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
- Coverage   74.28%   74.27%   -0.01%     
==========================================
  Files         357      358       +1     
  Lines       36280    36285       +5     
  Branches    36280    36285       +5     
==========================================
+ Hits        26950    26951       +1     
- Misses       7190     7195       +5     
+ Partials     2140     2139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 7ef0bca to 50b0311 Compare September 19, 2024 05:52
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 50b0311 to be41b48 Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from be41b48 to 908c8f1 Compare September 19, 2024 07:28
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 908c8f1 to 586d85b Compare September 19, 2024 07:33
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 586d85b to 34931fe Compare September 19, 2024 08:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 34931fe to 033822a Compare September 19, 2024 09:00
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split branch 2 times, most recently from 0ae8966 to 7c9e727 Compare September 19, 2024 11:41
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 8dd9c3c to 0e5ff51 Compare September 19, 2024 11:41
Copy link
Contributor Author

matan-starkware commented Sep 19, 2024

Merge activity

@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/main_run_split to graphite-base/874 September 19, 2024 11:55
@matan-starkware matan-starkware changed the base branch from graphite-base/874 to main September 19, 2024 11:55
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 0e5ff51 to 8187ed7 Compare September 19, 2024 11:56
@matan-starkware matan-starkware merged commit 1ad069a into main Sep 19, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants