Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): remove test code from production code #876

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 19, 2024

This overrides the default by adding a network receiver to simulate a faulty network


This change is Reviewable

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 77 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (1ad069a) to head (470e815).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/bin_utils.rs 0.00% 31 Missing ⚠️
...encing/papyrus_consensus/src/bin/run_simulation.rs 0.00% 28 Missing ⚠️
crates/papyrus_node/src/run.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   74.29%   74.24%   -0.05%     
==========================================
  Files         358      358              
  Lines       36280    36183      -97     
  Branches    36280    36183      -97     
==========================================
- Hits        26953    26864      -89     
+ Misses       7188     7182       -6     
+ Partials     2139     2137       -2     
Flag Coverage Δ
74.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_consensus branch 2 times, most recently from 43edf05 to 2c9058c Compare September 19, 2024 06:20
@matan-starkware matan-starkware changed the title refactor(node): create run_consensus binary refactor(node): remove test code from production code Sep 19, 2024
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 50b0311 to be41b48 Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from be41b48 to 908c8f1 Compare September 19, 2024 07:28
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 908c8f1 to 586d85b Compare September 19, 2024 07:33
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 586d85b to 34931fe Compare September 19, 2024 08:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 34931fe to 033822a Compare September 19, 2024 09:00
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 033822a to 15b50b5 Compare September 19, 2024 10:18
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 15b50b5 to 4385c24 Compare September 19, 2024 10:35
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 4385c24 to 52be37b Compare September 19, 2024 10:59
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 52be37b to 8dd9c3c Compare September 19, 2024 11:10
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_consensus branch 2 times, most recently from a10b3df to e56d670 Compare September 19, 2024 11:20
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/main_run_split_file branch from 8dd9c3c to 0e5ff51 Compare September 19, 2024 11:41
@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/main_run_split_file to graphite-base/876 September 19, 2024 11:56
@matan-starkware matan-starkware changed the base branch from graphite-base/876 to main September 19, 2024 12:07
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_consensus branch 5 times, most recently from 9af919c to 050def1 Compare September 22, 2024 08:02
Remove the test config and test setup from production code.
This causes us to create a new run_consensus binary for the test flow.
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 1 of 1 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

Copy link
Contributor Author

matan-starkware commented Sep 22, 2024

Merge activity

@matan-starkware matan-starkware merged commit 602ec6f into main Sep 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants