Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github.com/packethost/xff dependency #451

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Remove unused logger:

ea8a699
Select commit
Loading
Failed to load commit list.
Open

Remove github.com/packethost/xff dependency #451

Remove unused logger:
ea8a699
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 28, 2024 in 0s

65% (-4%) compared to 005a10d

Details

Codecov Report

Attention: Patch coverage is 70.68966% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 65%. Comparing base (005a10d) to head (ea8a699).

Files Patch % Lines
internal/ipxe/http/xff.go 71% 14 Missing and 2 partials ⚠️
internal/ipxe/http/http.go 0% 1 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #451    +/-   ##
====================================
- Coverage    69%    65%    -4%     
====================================
  Files        16     19     +3     
  Lines      1392   1535   +143     
====================================
+ Hits        962   1003    +41     
- Misses      403    503   +100     
- Partials     27     29     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.