-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: catch repo = pname usage #21
Comments
I fully agree with this. I'm going to use this issue as a justification for people asking why they can't use a variable for the The reason is that changing the Badstdenv.mkDerivation (finalAttrs: {
pname = "foobar";
src = fetchFromGitHub {
owner = "xxx";
repo = finalAttrs.pname;
rev = "zzz";
hash = "sha256-abcd";
};
}) Goodstdenv.mkDerivation (finalAttrs: {
pname = "foobar";
src = fetchFromGitHub {
owner = "xxx";
repo = "foobar";
rev = "zzz";
hash = "sha256-abcd";
};
}) |
Especially more concerning is finalAttrs.pname |
This was referenced Jul 3, 2023
This was referenced Jul 14, 2023
This was referenced Jul 26, 2023
This was referenced Aug 2, 2023
12 tasks
12 tasks
12 tasks
12 tasks
This was referenced Mar 12, 2024
13 tasks
This was referenced Mar 27, 2024
13 tasks
This was referenced May 10, 2024
This was referenced May 17, 2024
This was referenced May 30, 2024
Merged
This was referenced Jun 12, 2024
13 tasks
13 tasks
13 tasks
This was referenced Jul 15, 2024
13 tasks
This was referenced Aug 11, 2024
13 tasks
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Arising from a discussion here
repo = pname
is nice for DRY but probably creates a binding that goes too far.I suggest detecting when
repo
is anything other than a string literal.Thanks for this project!
The text was updated successfully, but these errors were encountered: